Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add qrcode to secret link modal #612

Merged
merged 2 commits into from
Sep 4, 2024
Merged

add qrcode to secret link modal #612

merged 2 commits into from
Sep 4, 2024

Conversation

kevodwyer
Copy link
Member

@kevodwyer kevodwyer commented Sep 4, 2024 •
edited
Loading

Requires Peergos PR: Peergos/Peergos#1176
desktop screenshot

desktop

mobile screenshot
mobile

@kevodwyer kevodwyer mentioned this pull request Sep 4, 2024
Merged
@ianopolous
Copy link
Member

Did you test it on a real QR code app? Can you post a screen shot for desktop and mobile?

@kevodwyer
Copy link
Member Author

Did you test it on a real QR code app? Can you post a screen shot for desktop and mobile?

I tested with my phone. it decoded the url.

@ianopolous ianopolous merged commit 74ac687 into master Sep 4, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ianopolous ianopolous ianopolous approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kevodwyer @ianopolous